watchface script with preview by 'yad' utility #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beroset
requested changes
Nov 12, 2025
Member
beroset
left a comment
beroset
left a comment
There was a problem hiding this comment.
There is a lot of duplicated code here. Refactoring into functions would make it a lot easier to understand and maintain.
|
|
||
| function restartCeres { | ||
| runWatchCommand "root" "systemctl restart user@1000" | ||
| runWatchCommand "ceres" "killall asteroid-launcher" |
Member
There was a problem hiding this comment.
Although it has a similar effect, this does not restart ceres.
| local watchface | ||
| local action | ||
| local default | ||
| if ! action=$(yad --title="Select action" --height=200 --list --column="action" \ |
Member
There was a problem hiding this comment.
Too many magic numbers: height=200, width=450, height=500.
| watchface=${watchface//|} | ||
| ;; | ||
| esac | ||
| # convert | chars to spaces |
Member
There was a problem hiding this comment.
This comment is apparently a cut-and-paste error and is misleading here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is 'watchface' script with preview by 'yad' utility